poorbarcode commented on code in PR #16758:
URL: https://github.com/apache/pulsar/pull/16758#discussion_r958447116
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -368,6 +369,31 @@ public MetadataStore
createConfigurationMetadataStore(PulsarMetadataEventSynchro
.build());
}
+ private static void ensureConfigIsAppropriate(ServiceConfiguration
configuration){
Review Comment:
Already fixed
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -368,6 +369,31 @@ public MetadataStore
createConfigurationMetadataStore(PulsarMetadataEventSynchro
.build());
}
+ private static void ensureConfigIsAppropriate(ServiceConfiguration
configuration){
+ if (configuration.isTransactionPendingAckBatchedWriteEnabled()){
+ if (configuration.getTransactionPendingAckBatchedWriteMaxRecords()
< 10){
+ throw new IllegalArgumentException("Txn pending ack batched
write max records suggestion at least 10");
+ }
+ if (configuration.getTransactionPendingAckBatchedWriteMaxSize() <
1024 * 128){
Review Comment:
Already fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
