tisonkun commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r959417237
##########
bin/pulsar:
##########
@@ -177,17 +177,23 @@ if [ ! -f "${PY_INSTANCE_FILE}" ]; then
PY_INSTANCE_FILE=${BUILT_PY_INSTANCE_FILE}
fi
-# find pulsar sql presto distribution location
-check_presto_libraries() {
- if [ ! -d "${PRESTO_HOME}" ]; then
-
-
BUILT_PRESTO_HOME="${SQL_HOME}/presto-distribution/target/pulsar-presto-distribution"
- if [ ! -d "${BUILT_PRESTO_HOME}" ]; then
- echo "\nCouldn't find presto distribution.";
- echo "Make sure you've run 'mvn package'\n";
- exit 1;
+# find pulsar sql trino distribution location
+check_trino_libraries() {
+ if [ ! -d "${TRINO_HOME}" ]; then
+ # TODO: As PIP-200 accepted, this compatibility is not promised.
Refactor when we drop this b/w compatibility.
+ FALLBACK_PRESTO_HOME="${PULSAR_HOME}/lib/presto"
Review Comment:
Concretely, <= 2.11 works with prestosql 334 or 333 under lib/presto, >=
2.12 works with trino 353 with breaking changes.
By no means one uses 2.12 wants to "fallback" to the previous lib folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
