poorbarcode commented on code in PR #17338:
URL: https://github.com/apache/pulsar/pull/17338#discussion_r960370138
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -264,13 +265,19 @@ protected void internalDeleteNamespace(AsyncResponse
asyncResponse, boolean auth
}
boolean isEmpty;
- List<String> topics;
+ Set<String> partitionedTopicNames = new HashSet<>();
+ Set<String> topicNames = new HashSet<>();
try {
- topics =
pulsar().getNamespaceService().getListOfPersistentTopics(namespaceName)
- .get(config().getMetadataStoreOperationTimeoutSeconds(),
TimeUnit.SECONDS);
- topics.addAll(getPartitionedTopicList(TopicDomain.persistent));
- topics.addAll(getPartitionedTopicList(TopicDomain.non_persistent));
- isEmpty = topics.isEmpty();
+ if (policies == null ||
CollectionUtils.isEmpty(policies.replication_clusters)){
Review Comment:
Hi @nodece
The cause has been identified:
1. Firstly: creating `non persistent topic` will deny when not set
replication_clusters.
2. The namespace created in V1 must manually set the `replicator` policy to
use `non persistent topic`
3. The namespace created in V2 will automatically set `replicator` policy
So this code is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
