tjiuming commented on code in PR #17041:
URL: https://github.com/apache/pulsar/pull/17041#discussion_r960864452
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java:
##########
@@ -126,6 +131,9 @@ public CompletableFuture<Boolean> asyncReload(String key,
Boolean oldValue,
}
}
});
+
+ this.metadataStoreName = poolName + "-" + ID.getAndIncrement();
Review Comment:
1. there are more than 1 Metadata store, one for broker metadata, one for
dynamic config.
you can see metadataStoreUrl and configurationMetadataStoreUrl in
https://github.com/apache/pulsar/blob/master/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
2. the metadata store name generated by the same rule with ThreadPool, keep
align with ThreadPool
3. keep align with ThreadPool name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
