Pomelongan commented on code in PR #17378:
URL: https://github.com/apache/pulsar/pull/17378#discussion_r960730516
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -157,13 +157,13 @@ protected CompletableFuture<Void>
tryCreatePartitionsAsync(int numPartitions) {
}
List<CompletableFuture<Void>> futures = new ArrayList<>(numPartitions);
for (int i = 0; i < numPartitions; i++) {
- futures.add(tryCreatePartitionAsync(i, null));
+ futures.add(tryCreatePartitionAsync(i));
}
return FutureUtil.waitForAll(futures);
}
- private CompletableFuture<Void> tryCreatePartitionAsync(final int
partition, CompletableFuture<Void> reuseFuture) {
- CompletableFuture<Void> result = reuseFuture == null ? new
CompletableFuture<>() : reuseFuture;
Review Comment:
@gaozhangmin
IMHO：
The parameter reusefuture was added for a function in the PR #6478, but it
was later removed in the PR #9485, so it is reasonable to restore the parameter
to its original state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
