Gleiphir2769 commented on code in PR #805:
URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r961441881
##########
pulsar/producer_partition.go:
##########
@@ -843,33 +1018,24 @@ func (p *partitionProducer) internalSendAsync(ctx
context.Context, msg *Producer
return
}
+ // bc only works when DisableBlockIfQueueFull is false
+ bc := make(chan struct{})
sr := &sendRequest{
ctx: ctx,
msg: msg,
callback: callback,
flushImmediately: flushImmediately,
publishTime: time.Now(),
+ blockCh: bc,
}
p.options.Interceptors.BeforeSend(p, msg)
- if p.options.DisableBlockIfQueueFull {
Review Comment:
Yes, you're right. I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
