Gleiphir2769 opened a new pull request, #17447: URL: https://github.com/apache/pulsar/pull/17447
Fixes #17446 ### Motivation Producer may be permanently blocked by chunking messages when blockIfQueueFull is enabled. The reason for this bug is how the chunk message semaphore is acquired. https://github.com/apache/pulsar/blob/359cfa7bc05775bf6dd004f21b9907610ed3b3d5/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java#L520-L527 When a large message is split into a large number of chunks (i.e. the message is too big or the `chunkMaxMessageSize` is set too small), all the remaining semaphores will be acquired. The sending (send() and sendAsync()) of large message will be blocked by itself forever. By the way, once blockIfQueueFull/maxPendingMessages/chunking are enabled at the same time, this risk of deadlock exists even if the number of chunks of a single message is not very large. ### Modifications When chunking is enabled, the blockIfQueueFull is always disabled. ### Verifying this change - [x] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - *Added integration tests for end-to-end deployment with large payloads (10MB)* ### Does this pull request potentially affect one of the following parts: *If `yes` was chosen, please highlight the changes* - Dependencies (does it add or upgrade a dependency): (yes / no) - The public API: (yes / no) - The schema: (yes / no / don't know) - The default values of configurations: (yes / no) - The wire protocol: (yes / no) - The rest endpoints: (yes / no) - The admin cli options: (yes / no) - Anything that affects deployment: (yes / no / don't know) ### Documentation Check the box below or label this PR directly. Need to update docs? - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
