asafm commented on PR #17041: URL: https://github.com/apache/pulsar/pull/17041#issuecomment-1236334066
I commented @tjiuming Aside from style notations, there are 3 main things I would improve: 1. Metadata store name is not indicative enough - see comment 2. Add latency for failed ops - see comment 3. Move tests out of `PrometheusMetricsTest` - see comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
