[GitHub] [pulsar] AnonHxy commented on a diff in pull request #17269: [feature][broker]extend BrokerInterceptor for more scenes

[GitBox]

AnonHxy commented on code in PR #17269:
URL: https://github.com/apache/pulsar/pull/17269#discussion_r962735325


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1836,6 +1845,9 @@ protected void handleCloseConsumer(CommandCloseConsumer 
closeConsumer) {
             consumers.remove(consumerId, consumerFuture);
             commandSender.sendSuccessResponse(requestId);
             log.info("[{}] Closed consumer, consumerId={}", remoteAddress, 
consumerId);
+            if (getBrokerService().getInterceptor() != null) {
+                getBrokerService().getInterceptor().consumerClosed(this, 
consumer, null);

Review Comment:
   I have a minor question, when will the metadata(the 3rd paramters of 
`consumerClosed`) not be null, as well as `producerClosed`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org