coderzc commented on PR #17164: URL: https://github.com/apache/pulsar/pull/17164#issuecomment-1236872277
> In the description it says: "use a special prefix to prevent internal property loss." Why is a special prefix needed? What are the consequences of this changes? Is it backwards compatible? @coderzc Please explain this detail. In the original implementation, all key-value are removed when update subscription properties, this will cause internal property loss, so use a special prefix to prevent internal properties removed by `updateSubscriptionProperties ` https://github.com/apache/pulsar/blob/c1c3c86f83e6bece06c29bbdd6e5b1b1cb841ef5/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java#L1221-L1232 https://github.com/apache/pulsar/blob/2db3ed5a0e1df52da83244baada63c5a0da5924f/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
