lordcheng10 commented on PR #17151: URL: https://github.com/apache/pulsar/pull/17151#issuecomment-1236901436
> This is a breaking change and may prevent existing users from upgrading Pulsar. For example, using host names as subscriptions is a very common use case for our company. Host names commonly contain multiple `.` characters, but this PR makes it impossible to create subscriptions containing `.`. Therefore, this PR is unacceptable for us. > > At least, a flag should be added to the broker's configuration to enable/disable this check. Moreover, the current check is too strict. For example, even if a subscription contains `.`, we can remove it without any problem. So there is no need to prohibit the creation of such subscriptions. OK, I agree to only check for invisible characters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
