eolivelli commented on PR #17432: URL: https://github.com/apache/pulsar/pull/17432#issuecomment-1237116596
> Checking for IllegalArgumentException in some logic, should we fix all of them? Any other error is an unknown error and we must log it at WARN level. This patch is handling a very specific, well-known case. The patch explicitly handles only that case. > Also, should new exception extend ManagedLedgerException? No. ManagedLedgerException is a top level concept in Pulsar. we must not pollute it with this corner case. Probably some day we will handle in a better way this situation and we will prevent this case from happening (but I don't see a clear way to deal with it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
