nodece commented on code in PR #17318:
URL: https://github.com/apache/pulsar/pull/17318#discussion_r963205569
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageRedeliveryTest.java:
##########
@@ -324,6 +326,77 @@ public void testRedeliveryAddEpoch(boolean enableBatch)
throws Exception{
assertEquals(message.getValue(), test3);
}
+ @Test(dataProvider = "enableBatch")
+ public void testBatchReceiveRedeliveryAddEpoch(boolean enableBatch) throws
Exception{
+ final String topic = "testBatchReceiveRedeliveryAddEpoch";
+ final String subName = "my-sub";
+ ConsumerBase<String> consumer = ((ConsumerBase<String>)
pulsarClient.newConsumer(Schema.STRING)
+ .topic(topic)
+ .subscriptionName(subName)
+ .batchReceivePolicy(BatchReceivePolicy.builder().timeout(1000,
TimeUnit.MILLISECONDS).build())
+ .subscriptionType(SubscriptionType.Failover)
+ .subscribe());
+
+ Producer<String> producer = pulsarClient.newProducer(Schema.STRING)
+ .topic(topic)
+ .enableBatching(enableBatch)
+ .create();
+
+ String test1 = "Pulsar1";
+ String test2 = "Pulsar2";
+ String test3 = "Pulsar3";
+ producer.send(test1);
+
+ PersistentTopic persistentTopic = (PersistentTopic)
pulsar.getBrokerService().getTopics()
+ .get(TopicName.get("persistent://public/default/" +
topic).toString()).get().get();
+ PersistentDispatcherSingleActiveConsumer
persistentDispatcherSingleActiveConsumer =
+ (PersistentDispatcherSingleActiveConsumer)
persistentTopic.getSubscription(subName).getDispatcher();
+
+ Messages<String> messages;
+ Message<String> message;
+
+ consumer.setConsumerEpoch(1);
+ messages = consumer.batchReceive();
+ assertEquals(messages.size(), 0);
+ consumer.redeliverUnacknowledgedMessages();
+ messages = consumer.batchReceive();
+ assertEquals(messages.size(), 1);
+ message = messages.iterator().next();
+ consumer.acknowledgeCumulativeAsync(message).get();
+ assertEquals(message.getValue(), test1);
+
+ consumer.setConsumerEpoch(3);
+ producer.send(test2);
+ messages = consumer.batchReceive();
+ assertEquals(messages.size(), 0);
+ consumer.redeliverUnacknowledgedMessages();
+ messages = consumer.batchReceive();
+ assertEquals(messages.size(), 1);
+ message = messages.iterator().next();
+ assertEquals(message.getValue(), test2);
+ consumer.acknowledgeCumulativeAsync(message).get();
+
+ consumer.setConsumerEpoch(6);
+ producer.send(test3);
+ messages = consumer.batchReceive();
+ assertEquals(messages.size(), 0);
+
+ Field field =
consumer.getClass().getDeclaredField("connectionHandler");
+ field.setAccessible(true);
+ ConnectionHandler connectionHandler = (ConnectionHandler)
field.get(consumer);
+
+ field =
connectionHandler.getClass().getDeclaredField("CLIENT_CNX_UPDATER");
+ field.setAccessible(true);
+
Review Comment:
Use the following code instead.
```
ConnectionHandler connectionHandler = consumer.getConnectionHandler();
connectionHandler.cnx().channel().close();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
