Anonymitaet commented on code in PR #17455:
URL: https://github.com/apache/pulsar/pull/17455#discussion_r963239269
##########
site2/docs/client-libraries-go.md:
##########
@@ -846,43 +868,43 @@ ctx := context.Background()
// create producer
producer, err := client.CreateProducer(pulsar.ProducerOptions{
- Topic: topic,
- DisableBatching: true,
+ Topic: topic,
+ DisableBatching: true,
})
if err != nil {
- log.Fatal(err)
+ log.Fatal(err)
}
defer producer.Close()
// send 10 messages
-msgIDs := [10]MessageID{}
+msgIDs := [10]pulsar.MessageID{}
for i := 0; i < 10; i++ {
- msgID, err := producer.Send(ctx, &pulsar.ProducerMessage{
- Payload: []byte(fmt.Sprintf("hello-%d", i)),
- })
- assert.NoError(t, err)
- assert.NotNil(t, msgID)
- msgIDs[i] = msgID
+ msgID, _ := producer.Send(ctx, &pulsar.ProducerMessage{
Review Comment:
@nodece I'm on your side. Referencing the source material reduces
maintenance cost
@labuladong FYI: to reduce manual work, we (@SignorMercurio @urfreespace)
are trying to generate client configurations docs from code automatically
(https://github.com/apache/pulsar/pull/17198), which means we'll remove the
[configuration instructions -
table](https://pulsar.apache.org/docs/next/client-libraries-java#configure-producer)
from client doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
