poorbarcode opened a new pull request, #17487:
URL: https://github.com/apache/pulsar/pull/17487

   Fixes #17386
   
   ### Motivation
   
   In this test, we expect it works like this: 
   
   1. persistent broker data to ZK
   2. receive notice: broker data changes, and refresh bundle data in memory 
   3. persistent bundle data to ZK
   4. verify bundle data persist correctly
   5. delete namespace
   6. verify bundle data deleted
   
   But the flow works like this:
   1. persistent broker data to ZK
   2. <strong> (High light) race condition </strong>
   2-x. receive notice: broker data changes, and refresh bundle data in memory 
   2-x. persistent bundle data to ZK ( If the data in memory is not updated, it 
will not be written to ZK )
   3. ......
   
   ### Modifications
   
   - guarantee `step-3` executed after `step-2`
   - In this test, the original codes mock `ModularLoadManagerWrapper` to make 
`isCentralized` always return `true`. But this mock is completely unnecessary 
because that's `ModularLoadManagerWrapper.isCentralized` was exactly always 
returned `true`, so remove the mock. 
   
   ### Documentation
   
   - [ ] `doc-required` 
     
   - [ ] `doc-not-needed` 
     
   - [ ] `doc` 
   
   - [ ] `doc-complete`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to