michaeljmarshall commented on PR #15558: URL: https://github.com/apache/pulsar/pull/15558#issuecomment-1238862774
> I don't think we should hurry and port too many "improvements" like this to branch-2.10 @eolivelli - I think it depends on whether this is an improvement or a bug fix. The PR's description cites Prometheus documentation here: > Prometheus docs states "All lines for a given metric must be provided as one single group" - https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md#grouping-and-sorting When I first read that line, I interpreted it to mean lines with the same metric name, e.g. `http_requests_total`, must be grouped together, not that all metrics of the same type must be grouped together. However, it might be an ambiguous rule. At the very least, it seems like Prometheus does not require metrics of the same type to be grouped but DataDog does. @marksilcox - I am not familiar with DataDog. What is the consequence of these metrics being ungrouped for DataDog? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
