michaeljmarshall commented on code in PR #17456:
URL: https://github.com/apache/pulsar/pull/17456#discussion_r964408741
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2069,6 +2069,13 @@ public class ServiceConfiguration implements
PulsarConfiguration {
)
private String loadBalancerLoadSheddingStrategy =
"org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder";
+ @FieldContext(
+ category = CATEGORY_LOAD_BALANCER,
+ doc = "When 【current usage < average usage - threshold】, "
Review Comment:
Nit:
```suggestion
doc = "When [current usage < average usage - threshold], "
```
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2069,6 +2069,13 @@ public class ServiceConfiguration implements
PulsarConfiguration {
)
private String loadBalancerLoadSheddingStrategy =
"org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder";
+ @FieldContext(
+ category = CATEGORY_LOAD_BALANCER,
+ doc = "When 【current usage < average usage - threshold】, "
+ + "the broker with the highest load will be triggered to
unload"
+ )
+ private boolean enableLowerBoundaryShedding = false;
Review Comment:
What if we made the lower boundary a double between 0 and 1 and have it
default to 0? Then, the threshold is configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
