zymap commented on code in PR #17485:
URL: https://github.com/apache/pulsar/pull/17485#discussion_r964615033
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -2972,7 +2973,7 @@ public void asyncOffloadPrefix(Position pos,
OffloadCallback callback, Object ct
}
private void offloadLoop(CompletableFuture<PositionImpl> promise,
Queue<LedgerInfo> ledgersToOffload,
- PositionImpl firstUnoffloaded, Optional<Throwable> firstError) {
+ PositionImpl firstUnoffloaded,
Optional<Throwable> firstError) {
Review Comment:
It's better to avoid changing the code format. Because we haven't a standard
of that, everyone has their format.
It is also difficult to review if there has too much code format changes.
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -2972,7 +2973,7 @@ public void asyncOffloadPrefix(Position pos,
OffloadCallback callback, Object ct
}
private void offloadLoop(CompletableFuture<PositionImpl> promise,
Queue<LedgerInfo> ledgersToOffload,
- PositionImpl firstUnoffloaded, Optional<Throwable> firstError) {
+ PositionImpl firstUnoffloaded,
Optional<Throwable> firstError) {
Review Comment:
It's better to avoid changing the code format. Because we haven't a standard
of that, everyone has their format.
It is also difficult to review if there have too many code format changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
