tisonkun commented on code in PR #207:
URL: https://github.com/apache/pulsar-site/pull/207#discussion_r965719225
##########
site2/website-next/src/theme/DocVersionBanner/index.js:
##########
@@ -25,7 +25,7 @@ function UnreleasedVersionLabel({ siteTitle, versionMetadata
}) {
}}
>
{
- "This is unreleased documentation for {siteTitle} {versionLabel}
version."
+ "This documentation is for an unreleased {siteTitle} {versionLabel}
version of Apache Pulsar. "
Review Comment:
```suggestion
"This documentation is for an unreleased version of Apache Pulsar. "
```
Agree. Simply writing "an unreleased version" works fine for me.
##########
site2/website-next/src/theme/DocVersionBanner/index.js:
##########
@@ -41,7 +41,7 @@ function UnmaintainedVersionLabel({ siteTitle,
versionMetadata }) {
}}
>
{
- "This is documentation for {siteTitle} {versionLabel}, which is no
longer actively maintained."
+ "This documentation is for an out-of-date {siteTitle} {versionLabel}
version of Apache Pulsar. "
Review Comment:
```suggestion
"This documentation is for an out-of-date version of Apache Pulsar. "
```
Ditto. The sidebar and URL should already identify which version it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
