codelipenghui commented on PR #17041: URL: https://github.com/apache/pulsar/pull/17041#issuecomment-1240795071
@tjiuming > cluster label will be added automatically in PrometheusMetricsGeneratorUtils.generateSystemMetrics(...) for metadata store name Oh, I see. Good to know. > if I change protected AbstractMetadataStore() to protected AbstractMetadataStore(String name), there will be toooo many places need to fix, WDYT? I think it's the 100% right thing to do. If we don't have this change, we might need to explain to many users what the name exactly means. And I think that should be an important point that we missed before, if you are troubleshooting problems with the heap dump, it is hard to determine which one is the configuration store and which one is the metastore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
