lhotari commented on PR #17164: URL: https://github.com/apache/pulsar/pull/17164#issuecomment-1241536546
> @lhotari The internal properties are can't be set by `updateSubscriptionProperties`, them is invisible to the customer and only used to implement some pulsar feature, for example, store the list of delayed message index bucket snapshot in the [PIP-195](https://github.com/apache/pulsar/issues/16763) This is relevant context for the code changes that have been added. Why is the support for internal properties added in this PR? The PR title or description doesn't mention that. I'm suggesting that internal property support is removed from this PR and added in another PR with proper tests and code comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
