tisonkun commented on code in PR #17575:
URL: https://github.com/apache/pulsar/pull/17575#discussion_r967554873
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2337,7 +2336,7 @@ public class ServiceConfiguration implements
PulsarConfiguration {
category = CATEGORY_LOAD_BALANCER,
doc = "Supported algorithms name for namespace bundle split"
)
- private List<String> supportedNamespaceBundleSplitAlgorithms =
Lists.newArrayList("range_equally_divide",
+ private Set<String> supportedNamespaceBundleSplitAlgorithms =
Sets.newHashSet("range_equally_divide",
Review Comment:
> create an unmodifiable set
That's it! I think JDK provides only the unmodifiable set version and `new
HashSet<>()` which doesn't accept an element parameter. Thanks for your
investigation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
