tisonkun commented on code in PR #17296:
URL: https://github.com/apache/pulsar/pull/17296#discussion_r967588492
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -158,22 +161,25 @@ public class ServiceConfiguration implements
PulsarConfiguration {
@FieldContext(
category = CATEGORY_SERVER,
required = false,
- doc = "The metadata store URL for the configuration data. If
empty, we fall back to use metadataStoreUrl"
+ doc = """
+ The metadata store URL for the configuration data. If
empty, we fall back to use metadataStoreUrl"""
)
private String configurationMetadataStoreUrl;
@FieldContext(
category = CATEGORY_SERVER,
- doc = "The port for serving binary protobuf requests."
- + " If set, defines a server binding for
bindAddress:brokerServicePort."
- + " The Default value is 6650."
+ doc = """
+ The port for serving binary protobuf requests. \
+ If set, defines a server binding for
bindAddress:brokerServicePort. \
+ The Default value is 6650."""
Review Comment:
The original string context is not "strings joined", it's "strings
concatenation". So, please leave the content as is.
If you'd like to add a newline by using textblock. I don't have a strong
feeling here. Do as you like.
To sum up, either:
1. Revert the change;
2. Remove `\`.
is OK for me. `\` doesn't work because we do a simple thing more complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
