eolivelli commented on code in PR #17338:
URL: https://github.com/apache/pulsar/pull/17338#discussion_r967667290
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -281,16 +288,17 @@ protected void internalDeleteNamespace(AsyncResponse
asyncResponse, boolean auth
if (log.isDebugEnabled()) {
log.debug("Found topics on namespace {}", namespaceName);
}
- boolean hasNonSystemTopic = false;
- for (String topic : topics) {
+ for (String topic : partitionedTopicNames) {
if
(!pulsar().getBrokerService().isSystemTopic(TopicName.get(topic))) {
- hasNonSystemTopic = true;
- break;
+ asyncResponse.resume(new RestException(Status.CONFLICT,
"Cannot delete non empty namespace"));
Review Comment:
What about logging a line that reports the topic that is preventing the
deletion, here and below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
