tarunannapareddy commented on code in PR #17577:
URL: https://github.com/apache/pulsar/pull/17577#discussion_r967648881
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java:
##########
@@ -616,6 +642,25 @@ public CompletableFuture<Void>
acknowledgeCumulativeAsync(MessageId messageId, T
return doAcknowledgeWithTxn(messageId, AckType.Cumulative,
Collections.emptyMap(), txnImpl);
}
+ protected CompletableFuture<Void> acknowledgeCumulativeAsync(Map<String,
MessageId> topicToMessageIdMap) throws PulsarClientException {
+ return acknowledgeCumulativeAsync(topicToMessageIdMap, null);
+ }
+
+ protected CompletableFuture<Void> acknowledgeCumulativeAsync(Map<String,
MessageId> topicToMessageIdMap, Transaction txn) throws PulsarClientException {
Review Comment:
The base idea is to support cumulative acknowledgement over list of
messages. But using List is confusing for the users in case of multi topic
consumer. This Map directs them to maintain latest message for each partition
and use it correctly.
Can you please go through this email thread sent to [email protected]_
for full motivation and opinion of others
**[DISCUSS] User-friendly acknowledgeCumulative API on a partitioned topic
or multi-topics**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
