coderzc commented on code in PR #17164:
URL: https://github.com/apache/pulsar/pull/17164#discussion_r968068015
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -365,6 +367,48 @@ public void operationFailed(MetaStoreException e) {
return updateCursorPropertiesResult;
}
+ @Override
+ public CompletableFuture<Void> setCursorProperties(Map<String, String>
cursorProperties) {
+ Map<String, String> newProperties =
+ cursorProperties == null ? new HashMap<>() : new
HashMap<>(cursorProperties);
+ long stamp = cursorPropertiesUpdateLock.writeLock();
Review Comment:
> This lock will block admin handler thread, and the unlock depends on
metadata callback thread, it has potential deadlock risk (which depends on if
setCursorProperties is called on metadata callback thread).
Use the `ledger.getExecutor().executeOrdered(ledger.getName(), () -> {})` to
make execute them on the same thread to instead of use the lock? It would be
better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
