heesung-sn opened a new pull request, #17598:
URL: https://github.com/apache/pulsar/pull/17598
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see
*[Guideline - Pulsar PR Naming
Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
-->
<!-- Either this PR fixes an issue, -->
Fixes #<xyz>
<!-- or this PR is one task of an issue -->
Master Issue: #<xyz>
### Motivation
Currently, the load report frequency is hard-coded at 5secs, and the memory
usage is re-computed in the ZK report thread. In the high traffic environment,
when GC is frequent, the memory usage could fluctuate in 5 secs, and this could
result in writing load report to ZK too frequently. This PR provides configs to
tune the minimal frequency of load balance report and to ignore memory usage in
the load report update conditions.
<!-- Explain here the context, and why you're making that change. What is
the problem you're trying to solve. -->
### Modifications
<!-- Describe the modifications you've done. -->
- add loadBalancerReportUpdateMemoryUsageChecked (default true)
- add loadBalancerReportUpdateMinIntervalMilliSeconds (default 5000)
The default values are the same as now, so there should be no behavior
change after this PR.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [x] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc-required`
(Your PR needs to update docs and you will update later). It needs to update
the broker config doc.
https://pulsar.apache.org/docs/reference-configuration/#broker
- [] `doc-not-needed`
(Please explain why) loadBalancerReportUpdateMinIntervalMilliSeconds
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
