mattisonchao commented on code in PR #17318:
URL: https://github.com/apache/pulsar/pull/17318#discussion_r969306575
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java:
##########
@@ -430,22 +430,7 @@ protected CompletableFuture<Messages<T>>
internalBatchReceiveAsync() {
CompletableFuture<Messages<T>> result =
cancellationHandler.createFuture();
internalPinnedExecutor.execute(() -> {
if (hasEnoughMessagesForBatchReceive()) {
- MessagesImpl<T> messages = getNewMessagesImpl();
- Message<T> msgPeeked = incomingMessages.peek();
- while (msgPeeked != null && messages.canAdd(msgPeeked)) {
- Message<T> msg = incomingMessages.poll();
- if (msg != null) {
- decreaseIncomingMessageSize(msg);
Review Comment:
Looks like we will invoke `messageProcessed` after this change, and we will
add this message to
`unAckedMessageTracker`. is it what we expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
