marksilcox opened a new pull request, #17618: URL: https://github.com/apache/pulsar/pull/17618
Fixes #8407 Fixes #13865 ### Motivation Current broker prometheus metrics are not grouped by metric type which causes issues in systems that read these metrics (e.g. DataDog). Prometheus docs states "All lines for a given metric must be provided as one single group" - https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md#grouping-and-sorting Modifications Updated the namespace and topic prometheus metric generators to group the metrics under the appropriate type header. Updated function worker stats to include TYPE headers ### Verifying this change - [x] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: Added unit test to verify all metrics are grouped under correct type header ### Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API: (no) - The schema: (no) - The default values of configurations: (no) - The wire protocol: (no) - The rest endpoints: (no) - The admin cli options: (no) - Anything that affects deployment: (no) ### Documentation Need to update docs? - [X] `doc-not-needed` Changes to match prometheus spec -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
