Gleiphir2769 commented on code in PR #805:
URL: https://github.com/apache/pulsar-client-go/pull/805#discussion_r970254250
##########
pulsar/consumer_impl.go:
##########
@@ -533,17 +545,15 @@ func (c *consumer) Nack(msg Message) {
}
func (c *consumer) NackID(msgID MessageID) {
- mid, ok := c.messageID(msgID)
- if !ok {
- return
- }
-
- if mid.consumer != nil {
- mid.Nack()
+ partition := int(msgID.PartitionIdx())
Review Comment:
Same as above
##########
pulsar/consumer_impl.go:
##########
@@ -579,12 +589,13 @@ func (c *consumer) Seek(msgID MessageID) error {
return newError(SeekFailed, "for partition topic, seek command
should perform on the individual partitions")
}
- mid, ok := c.messageID(msgID)
- if !ok {
- return nil
+ if msgID.PartitionIdx() < 0 || int(msgID.PartitionIdx()) >=
len(c.consumers) {
Review Comment:
Same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
