shibd commented on code in PR #17410:
URL: https://github.com/apache/pulsar/pull/17410#discussion_r970260032
##########
pulsar-client-cpp/lib/ClientConnection.cc:
##########
@@ -1557,34 +1567,34 @@ void ClientConnection::close(Result result) {
}
lock.unlock();
- LOG_INFO(cnxString_ << "Connection closed");
+ LOG_INFO(cnxString_ << "Connection closed with " << result);
for (ProducersMap::iterator it = producers.begin(); it != producers.end();
++it) {
- HandlerBase::handleDisconnection(ResultConnectError,
shared_from_this(), it->second);
+ HandlerBase::handleDisconnection(result, shared_from_this(),
it->second);
Review Comment:
When this call `handleDisconnection` and param `result == ResultRetryable`,
`handleDisconnection` method should handle `ResultRetryable`?
https://github.com/apache/pulsar/blob/fb0f653eadcf6bf72eb8c8efcc29975da6e21267/pulsar-client-cpp/lib/HandlerBase.cc#L108-L121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
