codelipenghui commented on code in PR #17632: URL: https://github.com/apache/pulsar/pull/17632#discussion_r970623664
########## pulsar-broker/src/test/java/org/apache/pulsar/broker/PulsarServiceCloseTest.java: ########## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.broker; + +import static org.mockito.Mockito.spy; + +import lombok.extern.slf4j.Slf4j; +import org.apache.pulsar.broker.auth.MockedPulsarServiceBaseTest; +import org.testng.annotations.AfterMethod; +import org.testng.annotations.BeforeMethod; +import org.testng.annotations.Test; + +@Slf4j +public class PulsarServiceCloseTest extends MockedPulsarServiceBaseTest { + + @BeforeMethod + @Override + protected void setup() throws Exception { + super.internalSetup(); + } + + @AfterMethod(alwaysRun = true) + @Override + protected void cleanup() throws Exception { + super.internalCleanup(); + } + + protected PulsarService startBrokerWithoutAuthorization(ServiceConfiguration conf) throws Exception { + conf.setBrokerShutdownTimeoutMs(1000 * 60 * 5); + conf.setLoadBalancerSheddingIntervalMinutes(30); + PulsarService pulsar = spy(newPulsarService(conf)); + setupBrokerMocks(pulsar); + beforePulsarStartMocks(pulsar); + pulsar.start(); + log.info("Pulsar started. brokerServiceUrl: {} webServiceAddress: {}", pulsar.getBrokerServiceUrl(), + pulsar.getWebServiceAddress()); + return pulsar; + } + + @Test(timeOut = 30_000) + public void closeInTimeTest() throws Exception { + // The pulsar service is not used, so it should be closed gracefully in short time. + pulsar.close(); Review Comment: Can we add a check for the `LoadSheddingTask.java.future` is cancelled, or we can just add a method like `LoadSheddingTask.isCancelled` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
