dragonls commented on code in PR #17573:
URL: https://github.com/apache/pulsar/pull/17573#discussion_r970456697
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentSubscription.java:
##########
@@ -210,7 +210,7 @@ public void consumerFlow(Consumer consumer, int
additionalNumberOfMessages) {
@Override
public void acknowledgeMessage(List<Position> position, AckType ackType,
Map<String, Long> properties) {
- // No-op
+ updateLastActive();
Review Comment:
I found that non-persistent consumer ack will not send ack command to
broker, so removing the modification in `NonPersistentSubscription.java`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
