tisonkun commented on code in PR #17470: URL: https://github.com/apache/pulsar/pull/17470#discussion_r971440670
########## wiki/release/release-process.md: ########## @@ -175,7 +147,7 @@ This will leave the RPM/YUM and DEB repo files in `pulsar-client-cpp/pkg/rpm/RPM > Tips: If you get error `c++: internal compiler error: Killed (program > cc1plus)` when run `pulsar-client-cpp/pkg/deb/docker-build-deb.sh`. You may > need to expand your docker memory greater than 2GB. Review Comment: ```suggestion > **NOTE**: If you get error `c++: internal compiler error: Killed (program cc1plus)` when run `pulsar-client-cpp/pkg/deb/docker-build-deb.sh`. You may need to expand your docker memory greater than 2GB. ``` We can use `NOTE` consistently. ########## wiki/release/release-process.md: ########## @@ -467,11 +424,11 @@ cp pulsar-broker/target/docs/*.json site2/website/static/swagger/2.X.0 ``` Send out a PR request for review. -## 16. Write release notes +## Write release notes -Steps and examples see [Pulsar Release Notes Guide](https://docs.google.com/document/d/1cwNkBefKyV6OPbEXnUrcCdVZi0i2BezqL6vAL7VqVC0/edit#). +See [Pulsar Release Notes Guide](https://docs.google.com/document/d/1cwNkBefKyV6OPbEXnUrcCdVZi0i2BezqL6vAL7VqVC0/edit#). Review Comment: I hope we can inline this guide instead of holding a dangling Google Docs page. But it can be a follow-up. ########## wiki/release/release-process.md: ########## @@ -592,10 +549,13 @@ svn ls https://dist.apache.org/repos/dist/release/pulsar svn rm https://dist.apache.org/repos/dist/release/pulsar/pulsar-2.Y.0 ``` -## 21. Move branch to next version +## Move release branch to next version -Follow the instructions in step 6, but run the script on the release branch. +Run the following commands in release branches. ```shell ./src/set-project-version.sh 2.X.Y-SNAPSHOT + +git commit -m 'Bumped version to 2.X.Y-SNAPSHOT' -a Review Comment: ```suggestion git add . git commit -s -m 'Bumped version to 2.X.Y-SNAPSHOT' ``` In case of the files aren't tracked yet. ########## wiki/release/release-process.md: ########## @@ -452,7 +403,13 @@ Note that it builds the docs within a docker image, so you'll need to have docke Once the docs are generated, you can add them and submit them in a PR. The expected doc output is `site2/website/static/api/python`. -## 15. Update swagger file +## Publish MacOS libpulsar package + +**This step can be skipped if the major version number is not latest.** + +Release a new version of libpulsar for MacOS, You can follow the example [here](https://github.com/Homebrew/homebrew-core/pull/53514) Review Comment: ```suggestion Release a new version of libpulsar on Homebrew, You can follow the example [here](https://github.com/Homebrew/homebrew-core/pull/53514). ``` ########## wiki/release/release-process.md: ########## @@ -311,9 +284,25 @@ The vote should be open for at least 72 hours (3 days). Votes from Pulsar PMC me will be considered binding, while anyone else is encouraged to verify the release and vote as well. -If the release is approved here, we can then proceed to next step. +If the release is approved here, we can then proceed to next step. Otherwise, we should repeat the previous steps and prepare another candidate release to vote. + +## Move master branch to next version + +NOTE: This is for major releases only. Review Comment: ```suggestion > **NOTE**: This is for major releases only. ``` Consistent format. ########## wiki/release/release-process.md: ########## @@ -242,31 +216,24 @@ minutes. Once complete click "Refresh" and now a link to the staging repository should be available, something like https://repository.apache.org/content/repositories/orgapachepulsar-XYZ +## Publish release candidate docker images -## 6. Move master branch to next version - -We need to move master version to next iteration `X + 1`. - -``` -git checkout master -./src/set-project-version.sh 2.Y.0-SNAPSHOT +Run the following commands. Review Comment: ```suggestion Run the following commands: ``` ########## wiki/release/release-process.md: ########## @@ -382,13 +352,13 @@ This is alternative to A. when the user has access to apachepulsar org in hub.do 4. Once it is merged, the chart will be automatically released to Github releases at https://github.com/apache/pulsar-helm-chart and updated to https://pulsar.apache.org/charts. -## 12. Publish Python Clients +## Publish Python Clients > **NOTES** > > 1. You need to create an account on PyPI: > https://pypi.org/project/pulsar-client/ Review Comment: ```suggestion > 1. You need to create an account on PyPI: https://pypi.org/account/register/ ``` ########## wiki/release/release-process.md: ########## @@ -452,7 +403,13 @@ Note that it builds the docs within a docker image, so you'll need to have docke Once the docs are generated, you can add them and submit them in a PR. The expected doc output is `site2/website/static/api/python`. -## 15. Update swagger file +## Publish MacOS libpulsar package Review Comment: ```suggestion ## Publish Homebrew libpulsar package ``` It's actually a Homebrew formula and can be used even in Linux OS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
