Jason918 commented on code in PR #17228:
URL: https://github.com/apache/pulsar/pull/17228#discussion_r971456553
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -2957,7 +2998,12 @@ public void asyncOffloadPrefix(Position pos,
OffloadCallback callback, Object ct
promise.whenComplete((result, exception) -> {
offloadMutex.unlock();
if (exception != null) {
- callback.offloadFailed(new
ManagedLedgerException(exception), ctx);
+ Throwable t =
FutureUtil.unwrapCompletionException(exception);
Review Comment:
why don't we call `asyncRefreshLedgersInfoOnBadVersion` here but in
`offloadPrefix`?
`asyncOffloadPrefix` is a public method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
