[GitHub] [pulsar] youzipi commented on a diff in pull request #17275: [cleanup][broker][Modernizer] fix violations in pulsar-broker

Thu, 15 Sep 2022 05:03:28 -0700 


youzipi commented on code in PR #17275:
URL: https://github.com/apache/pulsar/pull/17275#discussion_r971898266


##########
pulsar-broker/pom.xml:
##########
@@ -432,9 +432,15 @@
           <failOnViolations>true</failOnViolations>
           <javaVersion>17</javaVersion>
           <ignorePackages>
-            <ignorePackage>org.apache.pulsar.broker</ignorePackage>
+            <ignorePackage>org.apache.pulsar.broker.admin</ignorePackage>
+            <ignorePackage>org.apache.pulsar.broker.namespace</ignorePackage>
+            <ignorePackage>org.apache.pulsar.broker.service</ignorePackage>
+            <ignorePackage>org.apache.pulsar.broker.stats</ignorePackage>
             <ignorePackage>org.apache.pulsar.client</ignorePackage>
           </ignorePackages>
+          <exclusionPatterns>
+            
<exclusionPattern>java/lang/StringBuffer."&lt;init&gt;":.*</exclusionPattern>

Review Comment:
   
   there is a conflict between mockito and moderinizer:
   moderinizer prefers `StringBuilder` instead of `StringBuffer` **always**,
   but `Mockito.doReturn(new 
StringBuilder("http://127.0.0.1:8080";)).when(request).getRequestURL();` will 
fail in CI as type not match.
   
   former discussion:
   https://github.com/apache/pulsar/pull/17275#discussion_r963809645



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to