sijie commented on a change in pull request #4211:
[issue#4155][pulsar-clients]Support key value schema versioning
URL: https://github.com/apache/pulsar/pull/4211#discussion_r281064498
##########
File path:
pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/KeyValueSchemaTest.java
##########
@@ -238,8 +241,8 @@ public void testNotAllowNullSchemaEncodeAndDecode() {
@Test
public void testDefaultKeyValueEncodingTypeSchemaEncodeAndDecode() {
- AvroSchema<Foo> fooSchema =
AvroSchema.of(SchemaDefinition.<Foo>builder().withPojo(Foo.class).build());
- AvroSchema<Bar> barSchema =
AvroSchema.of(SchemaDefinition.<Bar>builder().withPojo(Bar.class).build());
+ JSONSchema<Foo> fooSchema =
JSONSchema.of(SchemaDefinition.<Foo>builder().withPojo(Foo.class).build());
Review comment:
why did you change this method from AVRO schema to JSON schema？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
