michaeljmarshall commented on code in PR #17686:
URL: https://github.com/apache/pulsar/pull/17686#discussion_r973266164
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractBaseDispatcher.java:
##########
@@ -220,6 +229,11 @@ public int
filterEntriesForConsumer(Optional<MessageMetadata[]> optMetadataArray
}
+ if (serviceConfig.isDispatchThrottlingForFilteredEntriesEnabled()) {
Review Comment:
I just noticed that `isDispatchOrPrecisePublishRateLimiter` is always true
in this class, so there are no issues with getting the permits after delivery.
We'll allow for some over-delivery, and then we will throttle consumers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
