codelipenghui commented on code in PR #17398:
URL: https://github.com/apache/pulsar/pull/17398#discussion_r974163755
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -1919,6 +1919,11 @@ public class ServiceConfiguration implements
PulsarConfiguration {
doc = "The number of bytes before triggering automatic offload to long
term storage"
)
private long managedLedgerOffloadAutoTriggerSizeThresholdBytes = -1L;
+ @FieldContext(
+ category = CATEGORY_STORAGE_OFFLOADING,
+ doc = "The threshold to triggering automatic offload to long term
storage"
+ )
+ private long managedLedgerOffloadTimeThresholdInSeconds = -1L;
Review Comment:
@tjiuming I see the config name is
`managedLedgerOffloadTimeThresholdInSeconds`. It's better change to
`managedLedgerOffloadThresholdInSeconds`
In TopicPolicies, we have `managedLedgerOffloadThresholdInBytes`. Keeping
the config name in the same pattern will help users to find by configuration
name prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
