asafm commented on code in PR #17041:
URL: https://github.com/apache/pulsar/pull/17041#discussion_r973681673
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataStoreConfig.java:
##########
@@ -29,6 +29,9 @@
@Getter
@ToString
public class MetadataStoreConfig {
+ public static final String LOCAL_METADATA_STORE = "local-metadata-store";
+ public static final String STATE_METADATA_STORE = "state-metadata-store";
Review Comment:
>And I would suggest changing "local-metadata-store" -> "metadata-store",
just to keep consistent with the configuration name that we have in the
`broker.conf`.
I agree with that. Today the user knows this from configuration:
`metadataStoreUrl` and `configurationMetadataStoreUrl` so when they see a label
name, they need to be able to match it with what they configured, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
