codelipenghui commented on PR #17318:
URL: https://github.com/apache/pulsar/pull/17318#issuecomment-1252049604

   > @codelipenghui Seem cannot judge the consumer epoch before offer to the 
incoming queue. Because, when the incoming queue has messages and the user 
invoke redeliverUnacknowledgedMessages at this time, these invalid epoch 
message also will return to the user.
   
   We should clean up the receiver queue when users invoke the 
`redeliverUnacknowledgedMessages` method?
   
   > Because the user may call the receive and redeliverUnacknowledgedMessages 
methods from multiple threads, in this case, user still may be receive old 
epoch messages. (TIP: this is not a good user example, but it may exist)
   
   We can make them happen on a single thread. And we used the pinned thread to 
complete the receive message request
   
   
https://github.com/apache/pulsar/blob/311ca9049f5be72e8d1c5df7dd984afc975ba9d8/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L474-L489


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to