congbobo184 commented on PR #17318: URL: https://github.com/apache/pulsar/pull/17318#issuecomment-1252108940
@shibd > > We should clean up the receiver queue when users invoke the redeliverUnacknowledgedMessages method? > > > > We can make them happen on a single thread. And we used the pinned thread to complete the receive message request > Yes, In this way, the epoch can be judged before offer the queue. @congbobo184 What do you think? I think yes, we only guarantee that offer to queue and redeliverUnacknowledgedMessages are in one thread, we can use pinned thread. > We also have methods that are invoked directly, it doesn't use pinned thread. > in this case, we don't need to think about `internalReceive `, > https://github.com/apache/pulsar/blob/1df63495f3ba6244391cffefb4081e22371c9b4a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L441-L458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
