michaeljmarshall opened a new pull request, #17754: URL: https://github.com/apache/pulsar/pull/17754
### Motivation While working on https://github.com/apache/pulsar/pull/17752, I noticed our build time was incorrect. It was set to `2020-01-22T09:10:15-0600`. This timestamp was inherited from the org.apache:apache:23 dependency, as you can see here: https://repo1.maven.org/maven2/org/apache/apache/23/apache-23.pom. Maven uses `project.build.outputTimestamp` for reproducible builds, as documented here: https://maven.apache.org/guides/mini/guide-reproducible-builds.html. The `git.build.time` we use to the the `PulsarVersion` comes from the `project.build.outputTimestamp` (when set), as documented here: https://github.com/git-commit-id/git-commit-id-maven-plugin/releases/tag/v4.0.2. When the property is null, the plugin uses `new Date()` to get the build time. https://github.com/git-commit-id/git-commit-id-maven-plugin/blob/80c6740ee268e1a524b2d0b1233801f2ac83881b/core/src/main/java/pl/project13/core/cibuild/BuildServerDataProvider.java#L138 If or when we decide to do reproducible builds, we will need to set this property anyway, so this solution does not prevent us from reproducible builds. ### Modifications * Set maven property `project.build.outputTimestamp` to an empty value to get more accurate build timestamp. ### Verifying this change I manually verified that this change enables `PulsarVersion.java` to generate correctly. ### Documentation - [x] `doc-not-needed` ### Matching PR in forked repository PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
