BewareMyPower commented on code in PR #17429: URL: https://github.com/apache/pulsar/pull/17429#discussion_r976137440
########## pulsar-client-cpp/.gitignore: ########## @@ -77,6 +77,7 @@ Makefile cmake_install.cmake CMakeFiles CMakeCache.txt +build/ Review Comment: Do not commit unrelated ignore path here. A CMake build directory can be any name, for example, I prefer `_builds` directory in my own. Adding such directories to `.gitignore` is bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
