eolivelli commented on code in PR #17833:
URL: https://github.com/apache/pulsar/pull/17833#discussion_r979458378
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageIdImpl.java:
##########
@@ -147,6 +147,12 @@ public MessageIdImpl prevBatchMessageId() {
ledgerId, entryId - 1, partitionIndex);
}
+ // MessageIdImpl is widely used as the key of a hash map, in this case, we
should convert the batch message id to
+ // have the correct hash code.
+ public MessageIdImpl getMessageIdImpl() {
Review Comment:
I would name this 'toMessageIdImpl()'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
