BewareMyPower commented on code in PR #17771:
URL: https://github.com/apache/pulsar/pull/17771#discussion_r979662754
##########
pulsar-client-cpp/CMakeLists.txt:
##########
@@ -345,10 +345,15 @@ include_directories(
${CURL_INCLUDE_DIRS}
${Protobuf_INCLUDE_DIRS}
${LOG4CXX_INCLUDE_PATH}
- ${GTEST_INCLUDE_PATH}
- ${GMOCK_INCLUDE_PATH}
Review Comment:
Even if these variables are not set, it won't make build failed.
Actually there are already a CI to verify the case when `BUILD_TESTS=OFF`
without GTest dependency. See
https://github.com/apache/pulsar/blob/f0aeb5acfb127c42d8f5dda65804617e69e77dd3/.github/workflows/ci-cpp-build.yaml#L231-L234
https://github.com/apache/pulsar/blob/f0aeb5acfb127c42d8f5dda65804617e69e77dd3/pulsar-client-cpp/pkg/deb/docker-build-deb.sh#L33-L34
https://github.com/apache/pulsar/blob/f0aeb5acfb127c42d8f5dda65804617e69e77dd3/pulsar-client-cpp/pkg/deb/build-deb.sh#L44
Your CMake option is wrong, you should use `-DBUILD_TESTS=OFF`, not
`-DTESTS=OFF`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
