tisonkun commented on code in PR #17733:
URL: https://github.com/apache/pulsar/pull/17733#discussion_r980590764
##########
docker/pulsar/scripts/install-pulsar-client.sh:
##########
@@ -20,6 +20,13 @@
set -x
+# TODO: remove these lines once grpcio doesn't need to compile from source on
ARM64 platform
+ARCH=$(uname -m | sed -r 's/aarch64/arm64/g' | awk '!/arm64/{$0="amd64"}1')
+if [ "${ARCH}" == "arm64" ]; then
+ apt update
+ apt -y install build-essential python3-dev
+fi
+
PYTHON_MAJOR_MINOR=$(python3 -V | sed -E 's/.*
([[:digit:]]+)\.([[:digit:]]+).*/\1\2/')
WHEEL_FILE=$(ls /pulsar/pulsar-client | grep "cp${PYTHON_MAJOR_MINOR}")
pip3 install /pulsar/pulsar-client/${WHEEL_FILE}[all]
Review Comment:
I made this patch to support ARM64-based docker images while keeping the
current workflow as is. That is, you should manually specify that you want to
build an ARM64-based image.
About automatically detecting platforms, see also
https://github.com/apache/pulsar/pull/17733#discussion_r975389715 that we have
some name matching problems.
And a clean solution would be, as @merlimat described, we publish C++/Python
client alone and download them from the package manager so that leveraging the
package manager's platform detect functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
