lhotari commented on code in PR #16618:
URL: https://github.com/apache/pulsar/pull/16618#discussion_r980726208
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java:
##########
@@ -202,7 +202,8 @@ private void
receiveSubscriptionUpdated(ReplicatedSubscriptionsUpdate update) {
private void startNewSnapshot() {
cleanupTimedOutSnapshots();
- if (topic.getLastDataMessagePublishedTimestamp() <
lastCompletedSnapshotStartTime) {
+ if (topic.getLastDataMessagePublishedTimestamp() <
lastCompletedSnapshotStartTime
+ || topic.getLastDataMessagePublishedTimestamp() == 0) {
Review Comment:
processing the snapshot will always take some time so it's not necessary to
check for equality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
