codelipenghui commented on code in PR #17831:
URL: https://github.com/apache/pulsar/pull/17831#discussion_r980699338
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -253,8 +254,25 @@ public void channelActive(ChannelHandlerContext ctx)
throws Exception {
} else {
log.info("{} Connected through proxy to target broker at {}",
ctx.channel(), proxyToTargetBrokerAddress);
}
- // Send CONNECT command
- ctx.writeAndFlush(newConnectCommand())
+ completeActive();
+ }
+
+ protected void completeActive() throws Exception {
+ sendConnectCommand(null, null, null);
Review Comment:
It should not be `sendConnectCommand(null, null, null);` right?
Otherwise, how can we pass the client's auth data to the new connection
command
https://github.com/apache/pulsar/pull/17831/files#diff-454fee306809542a71a0f3ce2cd97d7325afcfd7027dc3d156d303aff4c29902L275-L278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
