AnonHxy opened a new pull request, #17854:
URL: https://github.com/apache/pulsar/pull/17854

   ### Motivation
   
   Here we introduce a way to shrink the `maxBatchSize` of 
`BatchMessageContainerImpl`, which will reduce the producer memory waste.  And 
it will solve the two problems:
   
   1.  Reducing the memory waste will be very helpful for this issue:  
https://github.com/apache/pulsar/issues/17662
   2. The pr https://github.com/apache/pulsar/pull/15033 try to fix memory 
waste but brings a performance regression. This PR will correct it.
   
   ### Modifications
   
   Shrink `AbstractBatchMessageContainer#maxBatchSize` if meet the conditions.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   - Add test 
`org.apache.pulsar.client.impl.BatchMessageContainerImplTest#testUpdateMaxBatchSize`
   
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   PR in forked repository: <!-- ENTER URL HERE 
   
   After opening this PR, the build in apache/pulsar will fail and instructions 
will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since 
the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed 
in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments 
have
   been handled, the tests pass and the PR is approved by a reviewer.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to